Skip to content

Conversation

@AndyBlack
Copy link
Contributor

@AndyBlack AndyBlack commented Dec 10, 2025

When an entry with a sense had a variant entry without a sense and that variant entry then had another variant entry without a sense, getting the gloss/sense of that third entry had a null reference error. This fixes that problem.


This change is Reviewable

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

LCM Tests

    16 files  ±0      16 suites  ±0   3m 1s ⏱️ +10s
 2 850 tests +1   2 830 ✅ +1   20 💤 ±0  0 ❌ ±0 
11 348 runs  +4  11 180 ✅ +4  168 💤 ±0  0 ❌ ±0 

Results for commit d67c946. ± Comparison against base commit a3b309c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)

@AndyBlack AndyBlack merged commit 5dcb85f into master Dec 10, 2025
5 checks passed
@AndyBlack AndyBlack deleted the LT-22315 branch December 10, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants